linux-kernel - Re: [PATCH] x86, add hypervisor name to dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2012 14:58:29 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Avi Kivity <avi@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Marcelo Tostatti <mtosatti@...hat.com>,
	Ingo Molnar <mingo@...hat.com>, kvm@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH] x86, add hypervisor name to dump_stack()


* Prarit Bhargava <prarit@...hat.com> wrote:

> > Looks useful, but please don't waste a full new line on it 
> > but embedd it in the already existing status line that 
> > prints details like release and version.
> 
> Ingo, I thought about doing that but since x86_hyper can be 
> NULL (... maybe it should initialized to "Bare-metal" or "No 
> Hypervisor"?) I didn't want to break up the printk line.  I'll 
> look into doing it a different way...

You don't have to break it up - just initialize a name string 
to:

	const char *machine_name = "x86";
	const char *kernel_type = "native";

	if (x86_hyperv) {
		machine_name = x86_hyperv->name;
		kernel_type = "guest";
	}

And print it as:

          "[%s %s kernel]", machine_name, kernel_type

That way we'll get nice:

    ... [x86 native kernel]
    ... [KVM guest kernel]
    ... [Xen guest kernel]
    etc.

Printouts. Please use the naming I outlined above, that's how we 
refer to these kernels within arch/x86/.

(The above code is pseudocode, untested.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/