linux-kernel - Re: Fix memory leak in sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121024141506.GP18610@csclub.uwaterloo.ca>
Date:	Wed, 24 Oct 2012 10:15:06 -0400
From:	"Lennart Sorensen" <lsorense@...lub.uwaterloo.ca>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	linux-kernel@...r.kernel.org, linux@...rrawireless.com
Subject: Re: Fix memory leak in sierra_release()

On Wed, Oct 24, 2012 at 01:00:21PM +0200, Bjørn Mork wrote:
> "Lennart Sorensen" <lsorense@...lub.uwaterloo.ca> writes:
> 
> > I found a memory leak in sierra_release() (well sierra_probe() I guess)
> > that looses 8 bytes each time the driver releases a device.
> >
> > Here is the patch to fix it.
> >
> > diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> > index 01d882c..76ef95b 100644
> > --- a/drivers/usb/serial/sierra.c
> > +++ b/drivers/usb/serial/sierra.c
> > @@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
> >  			continue;
> >  		kfree(portdata);
> >  	}
> > +	kfree(serial->private);
> >  }
> >  
> >  #ifdef CONFIG_PM
> 
> Looks sensible to me, but needs a signed-off-by and CC to linux-usb.

Oh yeah.  I shouldn't send patches at the end of the day.

I will try again.

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/