linux-kernel - Re: [PATCH 106/193] drivers/net/wireless/rt2x00: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E86B2A8F-3C10-4B35-9F33-98D5A927E1E7@gmail.com>
Date:	Wed, 24 Oct 2012 18:21:07 +0200
From:	Gertjan van Wingerde <gwingerde@...il.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kees Cook <keescook@...omium.org>,
	Ivo van Doorn <IvDoorn@...il.com>,
	Helmut Schaa <helmut.schaa@...glemail.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 106/193] drivers/net/wireless/rt2x00: remove CONFIG_EXPERIMENTAL


On 23 okt. 2012, at 22:02, Kees Cook <keescook@...omium.org> wrote:

> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, remove it.
> 
> CC: Ivo van Doorn <IvDoorn@...il.com>
> CC: Gertjan van Wingerde <gwingerde@...il.com>
> CC: Helmut Schaa <helmut.schaa@...glemail.com>
> CC: "John W. Linville" <linville@...driver.com>
> Signed-off-by: Kees Cook <keescook@...omium.org>

I don't have a problem with the removal of the CONFIG_EXPERIMENTAL dependency, but I would like to retain the (EXPERIMENTAL) tag in the option string. We can then remove those tags when the support for those devices stabilize.

---
Gertjan

> ---
> drivers/net/wireless/rt2x00/Kconfig |   15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index c7548da..b3d7e9a 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -81,8 +81,7 @@ config RT2800PCI_RT33XX
>      Supported chips: RT3390
> 
> config RT2800PCI_RT35XX
> -    bool "rt2800pci - Include support for rt35xx devices (EXPERIMENTAL)"
> -    depends on EXPERIMENTAL
> +    bool "rt2800pci - Include support for rt35xx devices"
>    default y
>    ---help---
>      This adds support for rt35xx wireless chipset family to the
> @@ -91,8 +90,7 @@ config RT2800PCI_RT35XX
> 
> 
> config RT2800PCI_RT53XX
> -       bool "rt2800pci - Include support for rt53xx devices (EXPERIMENTAL)"
> -       depends on EXPERIMENTAL
> +       bool "rt2800pci - Include support for rt53xx devices"
>        default y
>        ---help---
>          This adds support for rt53xx wireless chipset family to the
> @@ -100,8 +98,7 @@ config RT2800PCI_RT53XX
>          Supported chips: RT5390
> 
> config RT2800PCI_RT3290
> -       bool "rt2800pci - Include support for rt3290 devices (EXPERIMENTAL)"
> -       depends on EXPERIMENTAL
> +       bool "rt2800pci - Include support for rt3290 devices"
>        default y
>        ---help---
>          This adds support for rt3290 wireless chipset family to the
> @@ -158,8 +155,7 @@ config RT2800USB_RT33XX
>      Supported chips: RT3370
> 
> config RT2800USB_RT35XX
> -    bool "rt2800usb - Include support for rt35xx devices (EXPERIMENTAL)"
> -    depends on EXPERIMENTAL
> +    bool "rt2800usb - Include support for rt35xx devices"
>    default y
>    ---help---
>      This adds support for rt35xx wireless chipset family to the
> @@ -167,8 +163,7 @@ config RT2800USB_RT35XX
>      Supported chips: RT3572
> 
> config RT2800USB_RT53XX
> -       bool "rt2800usb - Include support for rt53xx devices (EXPERIMENTAL)"
> -       depends on EXPERIMENTAL
> +       bool "rt2800usb - Include support for rt53xx devices"
>        ---help---
>          This adds support for rt53xx wireless chipset family to the
>          rt2800usb driver.
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/