linux-kernel - Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xa1thapjlqv1.fsf@mina86.com>
Date:	Wed, 24 Oct 2012 19:30:42 +0200
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	Randy Dunlap <rdunlap@...otime.net>,
	Felipe Balbi <balbi@...com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Date: Wed, 24 Oct 2012 16:40:10 +0200
>
> found by randconfig, Randy Dunlap and Stephen Rothwell:
>
> |drivers/built-in.o: In function `fsg_setup':
> |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf'
> |file_storage.c:(.text+0x24db98): undefined reference to `usb_gadget_get_string'
> |drivers/built-in.o: In function `fsg_bind':
> |file_storage.c:(.init.text+0xee42): undefined reference to `usb_ep_autoconfig_reset'
> |file_storage.c:(.init.text+0xee51): undefined reference to `usb_ep_autoconfig'
> |file_storage.c:(.init.text+0xee73): undefined reference to `usb_ep_autoconfig'
> |file_storage.c:(.init.text+0xee9e): undefined reference to `usb_ep_autoconfig'
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

At first it looks strange as FSG does not use composite, but yeah:

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
> for v3.7 please.
>
>  drivers/usb/gadget/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index bbcec83..66bc3ab 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -737,6 +737,7 @@ config USB_FUNCTIONFS_GENERIC
>  
>  config USB_FILE_STORAGE
>  	tristate "File-backed Storage Gadget (DEPRECATED)"
> +	select USB_LIBCOMPOSITE
>  	depends on BLOCK
>  	help
>  	  The File-backed Storage Gadget acts as a USB Mass Storage

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--

Content of type "application/pgp-signature" skipped