linux-kernel - Re: [PATCH] nfs: fix wrong object type in lockowner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121024194224.GB6697@fieldses.org>
Date:	Wed, 24 Oct 2012 15:42:24 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	ycnian@...il.com
Cc:	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] nfs: fix wrong object type in lockowner_slab

On Wed, Oct 24, 2012 at 02:44:19PM +0800, ycnian@...il.com wrote:
> From: Yanchuan Nian <ycnian@...il.com>
> 
> The object type in the cache of lockowner_slab is wrong, and it is better to fix it.
> 
> Signed-off-by: Yanchuan Nian <ycnian@...il.com>
> ---
>  fs/nfsd/nfs4state.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index cc894ed..1609eb2 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2325,7 +2325,7 @@ nfsd4_init_slabs(void)
>  	if (openowner_slab == NULL)
>  		goto out_nomem;
>  	lockowner_slab = kmem_cache_create("nfsd4_lockowners",
> -			sizeof(struct nfs4_openowner), 0, 0, NULL);
> +			sizeof(struct nfs4_lockowner), 0, 0, NULL);

Thanks!

The first three fields of each are the same, the rest is:

	struct nfs4_openowner {
		...
		pointer
		time_t
		unsigned char
	}

	struct nfs4_lockowner {
		...
		struct list_head
	}

Is it always true that

	sizeof(struct nfs4_openowner) >= sizeof9struct nfs4_lockowner)

?  I think so, in which case this isn't urgent.... Applying for 3.8.

--b.

>  	if (lockowner_slab == NULL)
>  		goto out_nomem;
>  	file_slab = kmem_cache_create("nfsd4_files",
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/