linux-kernel - Re: [REGRESSION] uml: signal.c build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2012 21:54:45 +0200
From:	Richard Weinberger <richard@....at>
To:	Matthew Leach <matthew@...tleach.net>
Cc:	linux-kernel@...r.kernel.org,
	Martin Pärtel <martin.partel@...il.com>
Subject: Re: [REGRESSION] uml: signal.c build errors

Am Wed, 24 Oct 2012 20:48:52 +0100
schrieb Matthew Leach <matthew@...tleach.net>:

> 
> Richard Weinberger <richard@....at> writes:
> > Am Wed, 24 Oct 2012 00:18:34 +0100
> >> I have tracked this down to [1] where, indeed, the type of
> >> sig_info is different; the second parameter in signal.c is
> >> 'siginfo_t' where as in as-layout.h the second parameter's type is
> >> declared as 'struct siginfo'.
> >> 
> >> [1]: d3c1cfcdb43e023ab1b1c7a555cd9e929026500a
> >
> > Looks like we have to revert that commit.
> > Moving everything to siginfo_t requires a non-trivial header cleanup
> > and may introduce new regressions.
> >
> > Matthew, does the attached revert patch help?
> 
> The revert did remove the errors for the compilation of signal.c, so
> that seems fine. I still get the following errors, however:
> 
>   CC      arch/um/os-Linux/sigio.o
>   CC      arch/um/os-Linux/signal.o
>   CC      arch/um/os-Linux/start_up.o
> arch/um/os-Linux/start_up.c: In function ‘check_coredump_limit’:
> arch/um/os-Linux/start_up.c:338:16: error: storage size of ‘lim’
> isn’t known arch/um/os-Linux/start_up.c:339:2: error: implicit
> declaration of function
> ‘getrlimit’ [-Werror=implicit-function-declaration]
> arch/um/os-Linux/start_up.c:339:22: error: ‘RLIMIT_CORE’ undeclared
> (first use in this function) arch/um/os-Linux/start_up.c:339:22:
> note: each undeclared identifier is reported only once for each
> function it appears in arch/um/os-Linux/start_up.c:347:22: error:
> ‘RLIM_INFINITY’ undeclared (first use in this function)
> arch/um/os-Linux/start_up.c:338:16: warning: unused variable
> ‘lim’ [-Wunused-variable] cc1: some warnings being treated as errors
> make[1]: *** [arch/um/os-Linux/start_up.o] Error 1 make: ***
> [arch/um/os-Linux] Error 2

Does adding
#include <sys/time.h>
#include <sys/resource.h>

to arch/um/os-Linux/start_up.c help?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/