linux-kernel - Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351111870.1917.4.camel@jtkirshe-mobl>
Date:	Wed, 24 Oct 2012 13:51:10 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] checkpatch.pl with commit
 058806007450489bb8f457b275e5cb5c946320c1

On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
> On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
> > With the recent commit to checkpatch.pl:
> > 
> > commit 058806007450489bb8f457b275e5cb5c946320c1
> > Author: Joe Perches <joe@...ches.com>
> > Date:   Thu Oct 4 17:13:35 2012 -0700
> > 
> >     checkpatch: check networking specific block comment style
> > 
> > We are seeing false positive warnings.  Here is an example of the
> > code the would generate a false warning:
> > 
> > #define foo	0x0000 /* foo comment */
> > 
> > checkpatch.pl generates a warnings that the */ should be on a separate
> > line, which in this case is incorrect.
> 
> Sorry 'bout that.  I believe it's fixed by:
> https://lkml.org/lkml/2012/10/14/267
> 

Yes, I confirm that the patch in the link you provided solves the issue
I was seeing.  Thanks, has the patch been accepted yet?  I see it is not
in Dave's NET tree as of yet.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)