linux-kernel - Re: [PATCH] openrisc: use kbuild.h instead of defining macros in asm-offset.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1351171980.6232.64.camel@jerome.southpole.se>
Date:	Thu, 25 Oct 2012 15:33:00 +0200
From:	Jonas Bonn <jonas@...thpole.se>
To:	James Hogan <james.hogan@...tec.com>
Cc:	linux@...ts.openrisc.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] openrisc: use kbuild.h instead of defining macros in
 asm-offset.c

On Thu, 2012-10-11 at 10:03 +0100, James Hogan wrote:
> This is modelled on commits such as the one below:
> 
> Commit fc1c3a003edb8a6778e64e10ef671a38c76c969e ("sh: use kbuild.h
> instead of defining macros in asm-offsets.c") introduced in v2.6.26.
> 
> Signed-off-by: James Hogan <james.hogan@...tec.com>

Thanks, looks good.  Will take this for 3.8.
/Jonas

> ---
> Note I haven't tested compilation on openrisc. I'd appreciate if
> somebody could check it doesn't break anything.
> 
>  arch/openrisc/kernel/asm-offsets.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/asm-offsets.c b/arch/openrisc/kernel/asm-offsets.c
> index 1a242a0..ddb7368 100644
> --- a/arch/openrisc/kernel/asm-offsets.c
> +++ b/arch/openrisc/kernel/asm-offsets.c
> @@ -34,15 +34,11 @@
>  #include <linux/mm.h>
>  #include <linux/io.h>
>  #include <linux/thread_info.h>
> +#include <linux/kbuild.h>
>  #include <asm/page.h>
>  #include <asm/pgtable.h>
>  #include <asm/processor.h>
>  
> -#define DEFINE(sym, val) \
> -		asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
>  int main(void)
>  {
>  	/* offsets into the task_struct */


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)