linux-kernel - Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon

Open Source and information security mailing list archives

Message-ID: <CADnq5_MTs65Pn_oCZCpxx5J_Lkdu9rnSJtaLFiNgbp_HLN+_4g@mail.gmail.com>
Date:	Thu, 25 Oct 2012 09:53:23 -0400
From:	Alex Deucher <alexdeucher@...il.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	airlied@...ux.ie, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	jglisse@...hat.com, alexander.deucher@....com, airlied@...hat.com
Subject: Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon

On Wed, Oct 24, 2012 at 10:42 AM, Peter Senna Tschudin
<peter.senna@...il.com> wrote:
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> statement S;
> position p,p1;
> @@
> S@p1;@p
>
> @script:python r2@
> p << r1.p;
> p1 << r1.p1;
> @@
> if p[0].line != p1[0].line_end:
>         cocci.include_match(False)
> @@
> position r1.p;
> @@
> -;@p
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>

Thanks!  I've added this to my patch queue.

Alex

>
> ---
>
> The full version of the semantic patch can be found at:
> http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
>
>  drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 573ed1b..5daf0c5 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
>         /* macro tile width & height */
>         palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
>         halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
> -       mtileb = (palign / 8) * (halign / 8) * tileb;;
> +       mtileb = (palign / 8) * (halign / 8) * tileb;
>         mtile_pr = surf->nbx / palign;
>         mtile_ps = (mtile_pr * surf->nby) / halign;
>         surf->layer_size = mtile_ps * mtileb * slice_pt;
> --
> 1.7.11.7
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives