linux-kernel - Re: [PATCH 1/2] openrisc: move sys_clone's stack determination to copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351181778.6232.71.camel@jerome.southpole.se>
Date:	Thu, 25 Oct 2012 18:16:18 +0200
From:	Jonas Bonn <jonas@...thpole.se>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] openrisc: move sys_clone's stack determination to
 copy_thread

On Thu, 2012-10-25 at 16:55 +0100, Al Viro wrote:
> On Thu, Oct 25, 2012 at 05:46:38PM +0200, Jonas Bonn wrote:
> > +		else
> > +			userregs->sp = regs->sp;	/* fork/clone */
> 
> What for?  userregs->sp will be equal to regs->sp at that point, unless
> your compiler is very badly broken.  You've copied *regs to *userregs
> wholesale, just above that if...

So true... that makes it even simpler.  Will resend.
/Jonas

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)