linux-kernel - Re: [RFC 3/3] libata: don't perform HW activity in devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121025172542.GG11442@htj.dyndns.org>
Date:	Thu, 25 Oct 2012 10:25:42 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Kevin Cernekee <cernekee@...il.com>
Subject: Re: [RFC 3/3] libata: don't perform HW activity in devres

On Thu, Oct 25, 2012 at 09:56:01AM -0700, Brian Norris wrote:
> devres functions are intended for simplified cleanup of memory and other
> software resources on device exit, not for hardware shutdown sequences.
> In addition, inducing hardware activity at device removal hamstrings
> some drivers (particularly ahci_platform) so that they cannot totally
> power off their hardware before removal, as devres cleanup occurs after
> the driver's exit() sequence.
> 
> More concretely, I experience the following bus error when using rmmod
> to remove (and power off) the SATA block on my SoC:

Shouldn't poweroff happen from ->port/host_stop()?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/