linux-kernel - Re: [PATCH] aoe: avoid using skb member after dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4918A364-8C8A-4F69-B03F-644339FC1A7B@coraid.com>
Date:	Thu, 25 Oct 2012 12:35:54 -0500
From:	Ed Cashin <ecashin@...aid.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit

On Oct 25, 2012, at 2:33 AM, Dan Carpenter wrote:

> On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote:
>> On Wed, 24 Oct 2012 14:26:13 -0400
>> Ed Cashin <ecashin@...aid.com> wrote:
>> 
>>> After calling dev_queue_xmit it is no longer safe to access the
>>> members of the skb.
>>> 
>>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>> 
>> hm, that was clever.  How did Dan detect this bug?
> 
> It was a Smatch thing, but it wasn't enabled by default.  I think I
> will enable it.  This is the second bug use after dev_queue_xmit()
> in two years.

OK, no more procrastinating.  I'm using smatch from today forward.

-- 
  Ed Cashin
  ecashin@...aid.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/