linux-kernel - Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121025194524.GV18814@opensource.wolfsonmicro.com>
Date:	Thu, 25 Oct 2012 20:45:25 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrey Smirnov <andrey.smirnov@...vergeddevices.net>
Cc:	hverkuil@...all.nl, mchehab@...hat.com, sameo@...ux.intel.com,
	perex@...ex.cz, tiwai@...e.de, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/6] Add the main bulk of core driver for SI476x code

On Tue, Oct 23, 2012 at 11:44:28AM -0700, Andrey Smirnov wrote:

> +	core->regmap = devm_regmap_init_si476x(core);
> +	if (IS_ERR(core->regmap)) {

This really makes little sense to me, why are you doing this?  Does the
device *really* layer a byte stream on top of I2C for sending messages
that look like marshalled register reads and writes?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)