linux-kernel - Re: [PATCH RFT] microblaze: dma-mapping: support debug_dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <508A49D3.2080303@monstr.eu>
Date:	Fri, 26 Oct 2012 10:29:07 +0200
From:	Michal Simek <monstr@...str.eu>
To:	shuah.khan@...com
CC:	kyungmin.park@...sung.com, m.szyprowski@...sung.com, arnd@...db.de,
	andrzej.p@...sung.com, microblaze-uclinux@...e.uq.edu.au,
	LKML <linux-kernel@...r.kernel.org>, shuahkhan@...il.com
Subject: Re: [PATCH RFT] microblaze: dma-mapping: support debug_dma_mapping_error

On 10/26/2012 01:29 AM, Shuah Khan wrote:
> Add support for debug_dma_mapping_error() call to avoid warning from
> debug_dma_unmap() interface when it checks for mapping error checked
> status. Without this patch, device driver failed to check map error
> warning is generated.
>
> Signed-off-by: Shuah Khan <shuah.khan@...com>
> ---
>   arch/microblaze/include/asm/dma-mapping.h |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/include/asm/dma-mapping.h b/arch/microblaze/include/asm/dma-mapping.h
> index 01d2282..4451c7a 100644
> --- a/arch/microblaze/include/asm/dma-mapping.h
> +++ b/arch/microblaze/include/asm/dma-mapping.h
> @@ -114,6 +114,7 @@ static inline void __dma_sync(unsigned long paddr,
>   static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
>   {
>   	struct dma_map_ops *ops = get_dma_ops(dev);

here should be empty line.

> +	debug_dma_mapping_error(dev, dma_addr);
>   	if (ops->mapping_error)
>   		return ops->mapping_error(dev, dma_addr);

Patch looks good to me. I was greping the latest mainline tree and I can't see
reference to debug_dma_mapping_error. Can you tell me where this function
is implemented.
I have also seen that you have sent several similar patches like this.

If you want to add it through any other tree here is my ACK:

Acked-by: Michal Simek <monstr@...str.eu>

I will definitely keep my eyes on it.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/