lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Oct 2012 13:14:37 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Jingoo Han <jg1.han@...sung.com>, 'Daniel Lezcano' <daniel.lezcano@...aro.org> Cc: "'Rafael J. Wysocki'" <rafael.j.wysocki@...el.com>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpuidle: add missing header include On Friday, October 26, 2012 01:30:07 PM Jingoo Han wrote: > This patch adds missing device.h header to fix build warnings as below: > > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by default] > In file included from drivers/cpuidle/driver.c:15:0: > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by default] > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is probably not what you want > [enabled by default] > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by default] > > This build warning is introduced by commit efeca1b > "cpuidle / sysfs: change function parameter". > > Signed-off-by: Jingoo Han <jg1.han@...sung.com> > Cc: Daniel Lezcano <daniel.lezcano@...aro.org> I fixed up the original patch. Daniel, I must say I'm less and less impressed by the quality of code I'm getting from you. Please improve it. Thanks, Rafael > --- > drivers/cpuidle/cpuidle.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle.h b/drivers/cpuidle/cpuidle.h > index a5bbd1c..2120d9e 100644 > --- a/drivers/cpuidle/cpuidle.h > +++ b/drivers/cpuidle/cpuidle.h > @@ -5,6 +5,8 @@ > #ifndef __DRIVER_CPUIDLE_H > #define __DRIVER_CPUIDLE_H > > +#include <linux/device.h> > + > /* For internal use only */ > extern struct cpuidle_governor *cpuidle_curr_governor; > extern struct list_head cpuidle_governors; > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists