lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Oct 2012 11:48:33 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: yan yan <clouds.yan@...il.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] debugfs: pass NULL as the last parameter of debugfs_print_regs32() On Sat, Oct 27, 2012 at 02:34:02AM +0800, yan yan wrote: > 2012/10/27 Greg KH <gregkh@...uxfoundation.org>: > > On Sat, Oct 27, 2012 at 01:55:42AM +0800, Yan Hong wrote: > >> Pass NULL instead of empty string to debugfs_print_regs32() when > >> prefix is not used, according to the intention of the code. > > > > Is this solving a problem? Is it wrong as-is? Is it causing an issue > > today? > > > > thanks, > > > > greg k-h > > Hmmm ... this function is rarely used, and maybe over-designed. The > 'prefix' feature can be actually removed -- nobody uses it. Then just remove it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists