linux-kernel - Re: [PATCH 4/5] IPMI: Fix some uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com>
Date:	Fri, 26 Oct 2012 12:41:13 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Corey Minyard <cminyard@...sta.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, minyard@....org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>
Subject: Re: [PATCH 4/5] IPMI: Fix some uninitialized warning

On Fri, Oct 26, 2012 at 12:35 PM, Corey Minyard <cminyard@...sta.com> wrote:
>
> I'll do a patch to switch it to uninitialized_var() for the next set of
> things I send.  Thanks.

Actually, I'm seriously considering getting rid of uninitialized_var().

The thing is an abomination, and we've already had one bug due to it
(real uninitialized variable that was incorrectly hidden by
uninitialized_var()).

The thing is moronic. The whole thing is almost entirely due to
compiler bugs (*stupid* gcc behavior), and we would have been better
off with an explicit (unnecessary) initialization that at least
doesn't cause random crashes etc if it turns out to be wrong.

So please don't use that abortion. Just initialize things to
0/NULL/whatever if gcc complains and you want to get rid of them.
Better than the crap that is uninitialized_var(), which just causes
silent random behavior if it is wrong.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/