linux-kernel - Re: [PATCH 2/2 v4] block/throttle: Add IO submitted information in blkio.throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 27 Oct 2012 18:47:36 +0800
From:	Robin Dong <robin.k.dong@...il.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Robin Dong <sanbai@...bao.com>,
	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	Tao Ma <boyu.mt@...bao.com>
Subject: Re: [PATCH 2/2 v4] block/throttle: Add IO submitted information in blkio.throttle

2012/10/27 Vivek Goyal <vgoyal@...hat.com>:
> On Fri, Oct 26, 2012 at 12:47:48PM +0800, Robin Dong wrote:
>
> [..]
>> @@ -1084,6 +1114,16 @@ static struct cftype throtl_files[] = {
>>               .private = offsetof(struct tg_stats_cpu, serviced),
>>               .read_seq_string = tg_print_cpu_rwstat,
>>       },
>> +     {
>> +             .name = "throttle.io_submit_bytes",
>
> Do we really need io_submit_bytes stats? Your need seems to be able to
> figure out if there are pending IOs in the group and if you need to
> increase the bandwidth. For that, isn't number of bios enough?

 I just want to be more consistent to "io_service_bytes" and "io_serviced" pair

>
> Also even if we retain bytes, let us change it to "io_submitted_bytes".

Since "io_service_bytes" is "service", I use "io_submit_bytes"....
Never mind, "io_submitted_bytes" is much better.

>
> Thanks
> Vivek



-- 
--
Best Regard
Robin Dong
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/