linux-kernel - Re: [PATCH] Regulator: core: Unregister when gpio request fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121028181540.GC4547@opensource.wolfsonmicro.com>
Date:	Sun, 28 Oct 2012 18:15:40 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	lrg@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Regulator: core: Unregister when gpio request fails.

On Sun, Oct 28, 2012 at 04:01:11PM +0100, Andrew Lunn wrote:
> If the gpio_request_one() fails, or returns EPROBE_DEFER, the
> regulator must be device_unregister()ed. When this is not done,
> there are WARNING: from sysfs:
> 
> WARNING: at fs/sysfs/file.c:343 sysfs_open_file+0x238/0x268()

Applied, thanks.  Please remember to submit patches with subject lines
that match the subsystem.  Also

> +                       goto wash;

that's a bit too cute and is going to hurt maintainability, meaningful
names are helpful when you get a bunch of things (eg, "clean_gpio").

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)