linux-kernel - Re: [PATCH 5/5] perf tool: Move dso_* related functions into dso object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121028211646.GB6754@infradead.org>
Date:	Sun, 28 Oct 2012 19:16:46 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 5/5] perf tool: Move dso_* related functions into dso
 object

Em Sun, Oct 28, 2012 at 07:42:01PM +0100, Jiri Olsa escreveu:
> On Sun, Oct 28, 2012 at 11:37:02AM -0200, Arnaldo Carvalho de Melo wrote:
> >     CC /home/acme/git/build/perf/util/dso-test-data.o
> > In file included from util/dso.c:2:
> > util/dso.h:87: error: ‘BUILD_ID_SIZE’ undeclared here (not in a function)
> >     CC /home/acme/git/build/perf/util/color.o
> > cc1: warnings being treated as errors
> > util/dso.c: In function ‘dso__binary_type_file’:
> > util/dso.c:45: error: implicit declaration of function ‘filename__read_debuglink’
> > util/dso.c:45: error: nested extern declaration of ‘filename__read_debuglink’
> > util/dso.c:51: error: ‘symbol_conf’ undeclared (first use in this function)
> > util/dso.c:51: error: (Each undeclared identifier is reported only once
> > util/dso.c:51: error: for each function it appears in.)
> > util/dso.c: In function ‘dso__delete’:
> > util/dso.c:435: error: implicit declaration of function ‘symbols__delete’
> > util/dso.c:435: error: nested extern declaration of ‘symbols__delete’
> > util/dso.c: In function ‘dso__read_running_kernel_build_id’:
> > util/dso.c:462: error: implicit declaration of function ‘sysfs__read_build_id’
> > util/dso.c:462: error: nested extern declaration of ‘sysfs__read_build_id’
> > util/dso.c: In function ‘__dsos__read_build_ids’:
> > util/dso.c:500: error: implicit declaration of function ‘filename__read_build_id’
> > util/dso.c:500: error: nested extern declaration of ‘filename__read_build_id’
> > util/dso.c: In function ‘dso__fprintf’:
> > util/dso.c:589: error: dereferencing pointer to incomplete type
> > util/dso.c:589: error: type defaults to ‘int’ in declaration of ‘__mptr’
> > util/dso.c:589: error: initialization from incompatible pointer type
> > util/dso.c:589: error: invalid use of undefined type ‘struct symbol’
> > util/dso.c:590: error: implicit declaration of function ‘symbol__fprintf’
> > util/dso.c:590: error: nested extern declaration of ‘symbol__fprintf’
> > make: *** [/home/acme/git/build/perf/util/dso.o] Error 1
> 
> ugh.. I have it rebased to your perf/core and it builds cleanly
> 
> Any chance there's something not pushed yet?

The only thing besides the four first patches in your series is one that
you acked:

commit 9175ce1f1244edd9f4d39605aa06ce5b0a50b8e0
Author: Andi Kleen <ak@...ux.intel.com>
Date:   Fri Oct 26 13:30:06 2012 -0700

    perf tools: Move parse_events error printing to parse_events_options


---------------




[acme@...dy linux]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.3 (Santiago)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/