linux-kernel - Re: [PATCH] sched, autogroup: fix crash on reboot when autogroup is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351430004.8685.17.camel@maggy.simpson.net>
Date:	Sun, 28 Oct 2012 06:13:24 -0700
From:	Mike Galbraith <efault@....de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org,
	Xiaotian Feng <dannyfeng@...cent.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] sched, autogroup: fix crash on reboot when autogroup is
 disabled

On Sun, 2012-10-28 at 11:25 +0100, Ingo Molnar wrote: 
> * Mike Galbraith <efault@....de> wrote:
> 

> > No knobs, no glitz, nada, just a cute little thing folks can turn
> > on if they don't want to muck about with cgroups and/or systemd.
> 
> Please also keep the Kconfig switch and reuse it to turn on the 
> 'autogroups' knob.
> 
> That way people with existing .config's don't have to change a 
> thing to get this functionality.

The Kconfig option is still there.  The noautogroup -> autogroup arg
change just makes it off by default (since an on/off switch would have
to be a full move everybody thing post 8323f26ce race fix), so distros
can make it available in their swiss army knife config, but it'll be out
of the way unless specifically asked for by the user at boot.

I can make it default 'on' by removing that arg change if you think
that's the better way to go, but opt in at boot sounded better to me
given there is no runtime on/off switch at all now.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/