linux-kernel - Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <508E4C29.4030308@imgtec.com>
Date:	Mon, 29 Oct 2012 09:28:09 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	<guanxuetao@...c.pku.edu.cn>
CC:	Arnd Bergmann <arnd@...db.de>, Jonas Bonn <jonas@...thpole.se>,
	<linux-arch@...r.kernel.org>, <linux@...nrisc.net>,
	<linux-kernel@...r.kernel.org>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	<linux-xtensa@...ux-xtensa.org>, Chris Zankel <chris@...kel.net>,
	"Max Filippov" <jcmvbkbc@...il.com>,
	Mike Frysinger <vapier@...too.org>,
	"Chen Liqin" <liqin.chen@...plusct.com>,
	Lennox Wu <lennox.wu@...il.com>,
	"Guan Xuetao" <gxt@...c.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include

On 29/10/12 01:28, guanxuetao@...c.pku.edu.cn wrote:
>> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
>> cacheflush.h being able to use I/O functions like readl and writel due
>> to circular include dependencies. It doesn't appear as if anything from
>> cacheflush.h is actually used by the generic io.h, so remove the
>> include.
>>
>> I've compile tested a defconfig compilation of blackfin, openrisc (which
>> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
>> definitions), and xtensa.
>>
>> Other architectures which use asm-generic/io.h are score and unicore32,
>> and looking at their io.h I don't see any obvious problems.
>>
>> Signed-off-by: James Hogan <james.hogan@...tec.com>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Jonas Bonn <jonas@...thpole.se>
>> Cc: Chris Zankel <chris@...kel.net>
>> Cc: Max Filippov <jcmvbkbc@...il.com>
>> Cc: Mike Frysinger <vapier@...too.org>
>> Cc: Chen Liqin <liqin.chen@...plusct.com>
>> Cc: Lennox Wu <lennox.wu@...il.com>
>> Cc: Guan Xuetao <gxt@...c.pku.edu.cn>
> 
> Acked-by: Guan Xuetao <gxt@...c.pku.edu.cn>

Thanks Guan

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/