linux-kernel - Re: [PATCH] ext3: get rid of the duplicate code on ext3_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121029103950.GA18767@quack.suse.cz>
Date:	Mon, 29 Oct 2012 11:39:50 +0100
From:	Jan Kara <jack@...e.cz>
To:	Zhao Hongjiang <zhaohongjiang37@...il.com>
Cc:	jack@...e.cz, akpm@...ux-foundation.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext3: get rid of the duplicate code on ext3_fill_super

On Mon 29-10-12 15:28:07, Zhao Hongjiang wrote:
> From: Zhao Hongjiang <zhaohongjiang@...wei.com>
> 
> Clean the duplicate code on ext3_fill_super cause the bellow
> also have it.
> 
> Signed-off-by: Zhao Hongjiang <zhaohongjiang@...wei.com>
  Thanks. I've merged the patch to my tree with somewhat updated changelog:
Setting s_mount_opt to 0 is unnecessary because we use kzalloc() for sb
allocation. s_resuid and s_resgid are set again few lines below based on
values in on disk superblock.

								Honza

> ---
>  fs/ext3/super.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 5366393..6e50223 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -1661,9 +1661,6 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
>  		return -ENOMEM;
>  	}
>  	sb->s_fs_info = sbi;
> -	sbi->s_mount_opt = 0;
> -	sbi->s_resuid = make_kuid(&init_user_ns, EXT3_DEF_RESUID);
> -	sbi->s_resgid = make_kgid(&init_user_ns, EXT3_DEF_RESGID);
>  	sbi->s_sb_block = sb_block;
> 
>  	blocksize = sb_min_blocksize(sb, EXT3_MIN_BLOCK_SIZE);
> -- 1.7.1
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/