linux-kernel - Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Oct 2012 20:02:35 +0900
From:	gshark <gshark.jeong@...il.com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

2012년 10월 29일 17:38, Axel Lin 쓴 글:
> We don't need the sysfs file to be world writable or group writable.
> This file is write-only, change it to S_IWUSR (0200).
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>   drivers/video/backlight/lm3639_bl.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index 585949b..6f7a20e 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -214,7 +214,7 @@ out_input:
>   
>   }
>   
> -static DEVICE_ATTR(bled_mode, 0666, NULL, lm3639_bled_mode_store);
> +static DEVICE_ATTR(bled_mode, S_IWUSR, NULL, lm3639_bled_mode_store);
>   
>   /* torch */
>   static void lm3639_torch_brightness_set(struct led_classdev *cdev,

It's also nice to us. Thank you Alex.
Acked-by: G.Shark Jeong<gshark.jeong@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/