linux-kernel - Re: [PATCH] aic7xxx_old: silence GCC warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351513026.2480.4.camel@dabdike.sthat4.btopenzone.com>
Date:	Mon, 29 Oct 2012 12:17:06 +0000
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aic7xxx_old: silence GCC warnings

On Mon, 2012-10-29 at 11:36 +0100, Paul Bolle wrote:
> On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote:
> > Building the aic7xxx_old driver triggers these GCC warnings:
> >     drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch]
> >     drivers/scsi/aic7xxx_old.c:7898:5: warning: case value '513' not in enumerated type 'ahc_chip' [-Wswitch]
> >     drivers/scsi/aic7xxx_old.c:8517:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch]
> >     drivers/scsi/aic7xxx_old.c:8510:5: warning: case value '513' not in enumerated type 'ahc_chip' [-Wswitch]
> > 
> > Fix these warnings by adopting the idiom used elsewhere in this driver.
> > Since AHC_EISA and AHC_VL are only ever set for AHC_AIC7770 this fix
> > should not lead to any functional change.
> > 
> > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > ---
> > 0) I noticed these warnings while building v3.6-rc6 on current Fedora
> > 17, using Fedora's default config.
> 
> Identical warnings can be seen while building v3.7-rc3. What's the
> status of my patch? Did anyone found some time to have a look at it?

the aic7xxx_old driver is in deep maintenance; I don't think anyone can
actually test changes to it anymore, so we just keep it around unchanged
for the odd really old card that can't be driven by the current driver.
For this reason, we tend only to do tested bug fixes to it because
no-one will notice if any error is introduced.

mvsas has a maintainer: poke them harder and aic94xx is currently
maintainerless, so it will depend on someone finding the time to test.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/