linux-kernel - Re: [PATCH] kvm tools: fix rbtree-interval search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121029165141.GG1109@gandi.net>
Date:	Mon, 29 Oct 2012 17:51:41 +0100
From:	William Dauchy <william@...di.net>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	Sasha Levin <levinsasha928@...il.com>,
	Pekka Enberg <penberg@...nel.org>,
	Asias He <asias.hejun@...il.com>, Ingo Molnar <mingo@...e.hu>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm tools: fix rbtree-interval search

On Oct29 14:12, Kirill A. Shutemov wrote:
> I've noticed message on kvm exit:
> 
>   Warning: serial8250__exit failed.
> 
> kvm tool is not able to remove ioport range which was added previously.
> 
> The issue is caused by bug in rbtree-interval. Search algorithm in
> rb_int_search_single() expects correct value of max_high. But the tree
> can contain leaf nodes, which never were updated by propagate_callback().
> For this kind of nodes high_max will be 0 and we will not be able to
> find and remove them.
> 
> Let's initialize max_high on RB_INT_INIT() time.
> 
> Fixing this bug makes other bug visible: propagate_callback() can be
> called for empty tree: node == NULL. The callback is not ready for empty
> tree. Let's fix that as well.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

I had the same issue but didn't found the time to fix it.
Applying the patch fixes the problem.

Tested-by: William Dauchy <william@...di.net>

Thanks,
-- 
William

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)