linux-kernel - Re: [PATCH] Staging: android: binder: Fixed multi-line strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121029215336.GA13740@kroah.com>
Date:	Mon, 29 Oct 2012 14:53:36 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anmol Sarma <unmole.in@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: binder: Fixed multi-line strings

On Fri, Oct 26, 2012 at 01:54:19PM +0530, Anmol Sarma wrote:
>  	if (vma == NULL) {
> -		pr_err("binder: %d: binder_alloc_buf failed to "
> -		       "map pages in userspace, no vma\n", proc->pid);
> +		pr_err("%d: binder_alloc_buf failed to map pages in userspace, no vma\n",
> +		 proc->pid);
>  		goto err_no_vma;
>  	}
>  
> @@ -585,8 +587,8 @@ static int binder_update_page_range(struct binder_proc *proc, int allocate,
>  		BUG_ON(*page);
>  		*page = alloc_page(GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO);
>  		if (*page == NULL) {
> -			pr_err("binder: %d: binder_alloc_buf failed "
> -			       "for page at %p\n", proc->pid, page_addr);
> +			pr_err("%d: binder_alloc_buf failed for page at %p\n",
> +			 proc->pid, page_addr);
>  			goto err_alloc_page_failed;
>  		}
>  		tmp_area.addr = page_addr;

What's with the very wierd indentation here for the second line?  Please
indent it properly, one space isn't ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/