linux-kernel - Re: [PATCH 5/5] fat: add mutex lock to fat_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121029164936.2022db6c.akpm@linux-foundation.org>
Date:	Mon, 29 Oct 2012 16:49:36 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	hirofumi@...l.parknet.co.jp, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

On Sun, 28 Oct 2012 10:53:43 +0900
Namjae Jeon <linkinjeon@...il.com> wrote:

> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> fat_nfs_get_inode does not hold i_mutex of parent directory.So add
> lock to fat_build_inode.

Well..  why?  Presumably this patch fixes some race.  A good
description of that race would be useful - partly because others may
then be able to suggest alternative ways of fixing that bug.

I'll merge these patches for some testing.

I did merge these patches three weekes ago:

fat-modify-nfs-mount-option.patch
fat-exportfs-rebuild-inode-if-ilookup-fails.patch
fat-exportfs-rebuild-inode-if-ilookup-fails-fix.patch
fat-exportfs-rebuild-directory-inode-if-fat_dget-fails.patch
documentation-update-nfs-option-in-filesystem-vfattxt.patch

But I have no record of Bruce or Ogawa having reviewed/acked them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/