linux-kernel - Re: [PATCH 01/32] nohz: Move nohz load balancer selection into idle logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <508F90A0.1030503@gmail.com>
Date:	Tue, 30 Oct 2012 16:32:32 +0800
From:	Charles Wang <0oo0.hust@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Clark Williams <clark.williams@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Li Zefan <lizf@...fujitsu.com>, Ingo Molnar <mingo@...nel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Mike Galbraith <efault@....de>,
	Alessio Igor Bogani <abogani@...nel.org>,
	Avi Kivity <avi@...hat.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Christoph Lameter <cl@...ux.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Geoff Levand <geoff@...radead.org>,
	Gilad Ben Yossef <gilad@...yossef.com>,
	Hakan Akkan <hakanakkan@...il.com>,
	Kevin Hilman <khilman@...com>,
	Max Krasnyansky <maxk@...lcomm.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	Sven-Thorsten Dietrich <thebigcorporation@...il.com>
Subject: Re: [PATCH 01/32] nohz: Move nohz load balancer selection into idle
 logic

calc_load_exit_idle depends on updated jiffies, so you shouldn't move 
this before tick_do_update_jiffies64.

And why should we do nohz_balance_enter_idle in tick_nohz_idle_exit? 
It's nohz_balance_exit_idle here.

Regards,
Charles

On 10/30/2012 04:27 AM, Steven Rostedt wrote:
［snipped］
 > @@ -573,7 +573,6 @@ static void tick_nohz_restart_sched_tick(struct 
tick_sched *ts, ktime_t now)
 >  	tick_do_update_jiffies64(now);
 >  	update_cpu_load_nohz();
 >
 > -	calc_load_exit_idle();
 >  	touch_softlockup_watchdog();
 >  	/*
 >  	 * Cancel the scheduled timer and restore the tick
 > @@ -628,6 +627,8 @@ void tick_nohz_idle_exit(void)
 >  		tick_nohz_stop_idle(cpu, now);
 >
 >  	if (ts->tick_stopped) {
 > +		nohz_balance_enter_idle(cpu);
 > +		calc_load_exit_idle();
 >  		tick_nohz_restart_sched_tick(ts, now);
 >  		tick_nohz_account_idle_ticks(ts);
 >  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/