linux-kernel - Re: [PATCH] Fix crypto api init for 3.6.4-rt10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1210301856390.2756@ionos>
Date:	Tue, 30 Oct 2012 18:57:37 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Milan Broz <mbroz@...hat.com>
cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Tvrtko Ursulin <tvrtko@...ulin.net>,
	linux-rt-users@...r.kernel.org, dm-crypt@...ut.de,
	linux-kernel@...r.kernel.org, okozina@...hat.com
Subject: Re: [PATCH] Fix crypto api init for 3.6.4-rt10

On Tue, 30 Oct 2012, Milan Broz wrote:

> Fix crypto api for 3.6.4-rt10 (broken only in realtime patchset)
> 
> In peterz-srcu-crypto-chain.patch the blocking notifier is changed
> to srcu notifier and added initialization to module init fucntion.
> 
> Later, in crypto-make-core-static-and-init-scru-early.patch, is that
> initialization added also to core_initcall().
> 
> This patch removes crypto_chain init from algapi initialization,
> because this function is called later and already initialized
> cryptomgr notifier is lost.

Grrr. So I forgot top zap the one Peter added. Stupid me.
 
> This cause a failure in initialization of larval algorithms,
> like e.g. cbc(aes).

Thanks for spotting!
 
> Signed-off-by: Milan Broz <mbroz@...hat.com>
> 
> --- crypto/algapi.c.old	2012-10-30 16:11:23.000000000 +0100
> +++ crypto/algapi.c	2012-10-30 16:12:14.988847944 +0100
> @@ -956,7 +956,6 @@ EXPORT_SYMBOL_GPL(crypto_xor);
>  
>  static int __init crypto_algapi_init(void)
>  {
> -	srcu_init_notifier_head(&crypto_chain);
>  	crypto_init_proc();
>  	return 0;
>  }
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/