linux-kernel - Re: [PATCH] omap2-clk: Add missing lcdc clock definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030181837.GM11908@atomide.com>
Date:	Tue, 30 Oct 2012 11:18:38 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	Paul Walmsley <paul@...an.com>, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Koen Kooi <koen@...inion.thruhere.net>,
	Matt Porter <mporter@...com>, Russ Dill <Russ.Dill@...com>
Subject: Re: [PATCH] omap2-clk: Add missing lcdc clock definition

* Pantelis Antoniou <panto@...oniou-consulting.com> [121030 11:04]:
> Looks like the lcdc clock definition got dropped.
> It is required for the LCD controller to work. Reintroduce.

This looks like a regression, can you also add the commit
causing it?

Regards,

Tony
 
> Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
> ---
>  arch/arm/mach-omap2/clock33xx_data.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
> index 1a45d6b..b7b7995 100644
> --- a/arch/arm/mach-omap2/clock33xx_data.c
> +++ b/arch/arm/mach-omap2/clock33xx_data.c
> @@ -867,6 +867,16 @@ static struct clk lcd_gclk = {
>  	.recalc		= &followparent_recalc,
>  };
>  
> +static struct clk lcdc_fck = {
> +	.name           = "lcdc_fck",
> +	.clkdm_name     = "lcdc_clkdm",
> +	.parent         = &lcd_gclk,
> +	.enable_reg     = AM33XX_CM_PER_LCDC_CLKCTRL,
> +	.enable_bit     = AM33XX_MODULEMODE_SWCTRL,
> +	.ops            = &clkops_omap2_dflt,
> +	.recalc         = &followparent_recalc,
> +};
> +
>  static struct clk mmc_clk = {
>  	.name		= "mmc_clk",
>  	.clkdm_name	= "l4ls_clkdm",
> @@ -1075,6 +1085,7 @@ static struct omap_clk am33xx_clks[] = {
>  	CLK(NULL,	"clkout2_ck",		&clkout2_ck,	CK_AM33XX),
>  	CLK(NULL,	"timer_32k_ck",		&clkdiv32k_ick,	CK_AM33XX),
>  	CLK(NULL,	"timer_sys_ck",		&sys_clkin_ck,	CK_AM33XX),
> +	CLK("da8xx_lcdc.0",     NULL,           &lcdc_fck,      CK_AM33XX),
>  };
>  
>  int __init am33xx_clk_init(void)
> -- 
> 1.7.12
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/