linux-kernel - Re: [Xen-devel] [PATCH] xen PVonHVM: require at least Xen 3.4 as dom0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030181732.GZ8912@reaktio.net>
Date:	Tue, 30 Oct 2012 20:17:32 +0200
From:	Pasi Kärkkäinen <pasik@....fi>
To:	Olaf Hering <olaf@...fle.de>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen PVonHVM: require at least Xen 3.4 as
 dom0

On Tue, Oct 30, 2012 at 05:05:05PM +0100, Olaf Hering wrote:
> The XenPVHVM extensions have not been tested much on very old
> hypervisors. At least Xen 3.4 gets some testing with the pvops kernel.
> 
> Require at least Xen 3.4 for the PVonHVM extensions. If an older
> hypervisor is detected the extensions will be disabled and the guest
> will only see emulated hardware.
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>
>

IIRC upstream Linux PVonHVM drivers do work OK today on RHEL5 Xen, 
which advertises itself as Xen 3.1.2-based..


-- Pasi


> ---
>  arch/x86/xen/enlighten.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 0cc41f8..8566fa8 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1543,17 +1543,10 @@ static void __init xen_hvm_init_shared_info(void)
>  
>  static void __init init_hvm_pv_info(void)
>  {
> -	int major, minor;
>  	uint32_t eax, ebx, ecx, edx, pages, msr, base;
>  	u64 pfn;
>  
>  	base = xen_cpuid_base();
> -	cpuid(base + 1, &eax, &ebx, &ecx, &edx);
> -
> -	major = eax >> 16;
> -	minor = eax & 0xffff;
> -	printk(KERN_INFO "Xen version %d.%d.\n", major, minor);
> -
>  	cpuid(base + 2, &pages, &msr, &ecx, &edx);
>  
>  	pfn = __pa(hypercall_page);
> @@ -1604,13 +1597,29 @@ static void __init xen_hvm_guest_init(void)
>  
>  static bool __init xen_hvm_platform(void)
>  {
> +	int major, minor, old = 0;
> +	uint32_t eax, ebx, ecx, edx, base;
> +	bool usable = true;
> +
>  	if (xen_pv_domain())
>  		return false;
>  
> -	if (!xen_cpuid_base())
> +	base = xen_cpuid_base();
> +	if (!base)
>  		return false;
>  
> -	return true;
> +	cpuid(base + 1, &eax, &ebx, &ecx, &edx);
> +
> +	major = eax >> 16;
> +	minor = eax & 0xffff;
> +
> +	/* Require at least Xen 3.4 */
> +	if (major < 3 || (major == 3 && minor < 4))
> +		usable = false;
> +	printk(KERN_INFO "Xen version %d.%d.%s\n",
> +		major, minor, usable ? "" : " (too old)");
> +
> +	return usable;
>  }
>  
>  bool xen_hvm_need_lapic(void)
> -- 
> 1.8.0
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xen.org
> http://lists.xen.org/xen-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/