linux-kernel - Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Oct 2012 17:01:59 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nel.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, tony.luck@...el.com,
	fenghua.yu@...el.com, len.brown@...el.com, rjw@...k.pl,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()

On Mon, Oct 29, 2012 at 11:26:31AM +0200, Mika Westerberg wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> These functions might be called from modules as well so make sure they are
> exported. In addition we implement empty version of acpi_unregister_gsi() and
> remove the one from pci_irq.c.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
> Although there are no modules that use this currently, we are working on
> ACPI 5 device enumeration support that is going to use these functions and
> some of that code can be compiled as a module.
> 
>  arch/x86/kernel/acpi/boot.c | 6 ++++++
>  drivers/acpi/pci_irq.c      | 5 -----
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index e651f7a..2616d2b 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -574,6 +574,12 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
>  
>  	return irq;
>  }
> +EXPORT_SYMBOL(acpi_register_gsi);

_GPL ?
> +
> +void acpi_unregister_gsi(u32 gsi)
> +{
> +}
> +EXPORT_SYMBOL(acpi_unregister_gsi);
>  
>  void __init acpi_set_irq_model_pic(void)
>  {
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index 0eefa12..1be25a5 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -495,11 +495,6 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
>  	return 0;
>  }
>  
> -/* FIXME: implement x86/x86_64 version */
> -void __attribute__ ((weak)) acpi_unregister_gsi(u32 i)
> -{
> -}
> -
>  void acpi_pci_irq_disable(struct pci_dev *dev)
>  {
>  	struct acpi_prt_entry *entry;
> -- 
> 1.7.12.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/