linux-kernel - Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1351570900.19193.3.camel@dhruva>
Date:	Tue, 30 Oct 2012 09:51:40 +0530
From:	Ashish Jangam <ashish.jangam@...tcummins.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Axel Lin <axel.lin@...ics.com>, Jean Delvare <khali@...ux-fr.org>,
	David Dajun Chen <dchen@...semi.com>,
	<lm-sensors@...sensors.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

On Mon, 2012-10-29 at 17:52 -0700, Guenter Roeck wrote:
> On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote:
> > Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3.
> > 
> > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > ---
> > Hi,
> >   This looks like a typo, but I don't have a hardware to test it.
> > Axel
> >  drivers/hwmon/da9055-hwmon.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/da9055-hwmon.c b/drivers/hwmon/da9055-hwmon.c
> > index 0b41f2c..3a3377c 100644
> > --- a/drivers/hwmon/da9055-hwmon.c
> > +++ b/drivers/hwmon/da9055-hwmon.c
> > @@ -54,7 +54,7 @@ static const u8 chan_mux[DA9055_ADC_TJUNC + 1] = {
> >  	[DA9055_ADC_VSYS]	= DA9055_ADC_MUX_VSYS,
> >  	[DA9055_ADC_ADCIN1]	= DA9055_ADC_MUX_ADCIN1,
> >  	[DA9055_ADC_ADCIN2]	= DA9055_ADC_MUX_ADCIN2,
> > -	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN1,
> > +	[DA9055_ADC_ADCIN3]	= DA9055_ADC_MUX_ADCIN3,
> >  	[DA9055_ADC_TJUNC]	= DA9055_ADC_MUX_T_SENSE,
> >  };
> 
> Very much loks like a typo.
> 
> David, Ashish, any comments ? I would like to get your Ack before applying it.
> 
> Thanks,
> Guenter
> 
Yes, its typo so you can apply the patch.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/