linux-kernel - Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030231124.GA2902@lizard>
Date:	Tue, 30 Oct 2012 16:11:25 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	yongd <yongd@...vell.com>
Cc:	Chris Ball <cjb@...top.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Daniel Drake <dsd@...top.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Wilson Callan <wilson.callan@...antsystems.com>,
	Ben Dooks <ben-linux@...ff.org>, zhangfei.gao@...vell.com,
	kevin.liu@...vell.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in
 sdhci_add_host

On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote:
> Sorry for my so late. And eventually these updated patches are here for your
> review. Thanks in advance.
> For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type,
> or the host controller detection interrupts will be redundantly enabled. And its
> comment is correspondingly updated.
> For patch 2, broaden SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for all detection
> types except S3C_SDHCI_CD_INTERNAL. Then also update the comment.
> For patch 3, no update.

They all look OK, but note that I did not check drivers' logic, so I hope
you carefully reviewed all the drivers yourself. :)

Unfortunately, you decided to go the dangerous way, instead of taking my
100%-safe approach (i.e.
http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg16555.html ),
which, to me, still makes more sense (of course :).

Anyways, I'm not opposed either, so hopefully it works:

	Reviewed-by: Anton Vorontsov <cbouatmailru@...il.com>

Thanks!
Anton.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/