linux-kernel - Re: [RFC 2/7] capebus: Add beaglebone board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030235714.GB12739@atomide.com>
Date:	Tue, 30 Oct 2012 16:57:15 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Koen Kooi <koen@...inion.thruhere.net>,
	Matt Porter <mporter@...com>, Russ Dill <Russ.Dill@...com>,
	linux-omap@...r.kernel.org
Subject: Re: [RFC 2/7] capebus: Add beaglebone board support

* Pantelis Antoniou <panto@...oniou-consulting.com> [121030 13:18]:
> On Oct 30, 2012, at 9:39 PM, Tony Lindgren wrote:
> 
> > * Pantelis Antoniou <panto@...oniou-consulting.com> [121030 12:00]:
> >> +
> >> +	priv->lcdc_oh = omap_hwmod_lookup("lcdc");
> >> +	if (priv->lcdc_oh == NULL) {
> >> +		dev_err(&pdev->dev, "Failed to lookup omap_hwmod lcdc\n");
> >> +		return -ENODEV;
> >> +	}
> >> +
> >> +	priv->lcdc_pdev = omap_device_build("da8xx_lcdc", 0, priv->lcdc_oh,
> >> +			&priv->lcd_pdata,
> >> +			sizeof(struct da8xx_lcdc_platform_data),
> >> +			NULL, 0, 0);
> >> +	if (priv->lcdc_pdev == NULL) {
> >> +		dev_err(&pdev->dev, "Failed to build LCDC device\n");
> >> +		return -ENODEV;
> >> +	}
> > 
> > ..and these kind of things need to become private to
> > arch/arm/mach-omap2, we already have it working for other
> > devices with device tree.
> > 
> > Regards,
> > 
> > Tony
> 
> I see,
> 
> I know that if the device driver is DTified it will pick up the hwmod automatically.
> The issue is that the driver is question is not yet; how would I go about
> creating the platform device and having it pick up the hwmod automatically?

Maybe you should make this DT only driver for omap? We already
have am33xx DT only to start with.

If you really need the platform device still, just take a look
at the many platform device creating files under arch/arm/mach-omap2.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/