linux-kernel - Re: [PATCH]Documentation: Chinese translation of Documentation/arm/kernel_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE8XmWo5YDu7iBVKH5Z2_EeAAePia24zwtfgPFJ0Cfxjz8Avwg@mail.gmail.com>
Date:	Wed, 31 Oct 2012 13:06:45 +0800
From:	Dongsheng Song <dongsheng.song@...il.com>
To:	Tekkaman Ninja <tekkamanninja@...il.com>
Cc:	Harry Wei <harryxiyou@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Dave Martin <dave.martin@...aro.org>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH]Documentation: Chinese translation of Documentation/arm/kernel_user_helpers.txt

Hi,

There have some misleading in the translation:

-------------------------------- origin  --------------------------------
User space is expected to bypass those helpers and implement those things
inline (either in the code emitted directly by the compiler, or part of
the implementation of a library call) when optimizing for a recent enough
processor that has the necessary native support, but only if resulting
binaries are already to be incompatible with earlier ARM processors due to
usage of similar native instructions for other things.  In other words
don't make binaries unable to run on earlier processors just for the sake
of not using these kernel helpers if your compiled code is not going to
use new instructions for other purpose.

-------------------------------- Fu Wei  --------------------------------
当对那些拥有基本原生支持的新型处理器的代码进行优化时，用户空间最好绕
过这些辅助代码并在内联函数中实现这些操作（无论是通过编译器在代码中直
接放置，还是作为库函数调用实现的一部分），而仅在其他处理器因使用相似
的本地指令而导致二进制结果已与早期 ARM 处理不兼容的情况下才使用这些
辅助代码。也就是说，如果你编译的代码不会为了其他目的使用新的指令，则
不要仅为了不使用这些内核辅助代码而导致二进制程序无法在早期处理器上运
行。
-------------------------------- me  --------------------------------
当对那些拥有原生支持的新型处理器进行代码优化时，如果已经在其它代码中
使用类似的新指令，从而导致二进制结果已与早期 ARM 处理器不兼容的情况下，
用户空间最好绕过这些辅助代码，并在内联函数中实现这些操作（无论是通过
编译器在代码中直接发出，还是作为库函数调用实现的一部分）。也就是说，
如果你编译的代码不会为了其他目的使用新指令，则不要仅为了不使用这些内核
辅助代码，导致二进制程序无法在早期处理器上运行。

The attachment is my review result.

--
Dongsheng

View attachment "kernel_user_helpers.txt" of type "text/plain" (7875 bytes)