linux-kernel - [PATCH] mmc: s3cmci: use tasklet_kill in device remove/release process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1351680525-27253-1-git-send-email-xtfeng@gmail.com>
Date:	Wed, 31 Oct 2012 18:48:45 +0800
From:	Xiaotian Feng <xtfeng@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Xiaotian Feng <dannyfeng@...cent.com>,
	Ben Dooks <ben-linux@...ff.org>, Chris Ball <cjb@...top.org>,
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org
Subject: [PATCH] mmc: s3cmci: use tasklet_kill in device remove/release process

Some driver uses tasklet_disable in device remove/release process,
tasklet_disable will inc tasklet->count and return. If the tasklet
is not handled yet under some softirq pressure, the tasklet will be
placed on the tasklet_vec, never have a chance to be excuted. This might
lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but
tasklet is disabled. tasklet_kill should be used in this case.

Signed-off-by: Xiaotian Feng <dannyfeng@...cent.com>
Cc: Ben Dooks <ben-linux@...ff.org>
Cc: Chris Ball <cjb@...top.org>
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-mmc@...r.kernel.org
---
 drivers/mmc/host/s3cmci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
index 4638dda..d70d0cc 100644
--- a/drivers/mmc/host/s3cmci.c
+++ b/drivers/mmc/host/s3cmci.c
@@ -1830,7 +1830,7 @@ static int __devexit s3cmci_remove(struct platform_device *pdev)
 
 	clk_put(host->clk);
 
-	tasklet_disable(&host->pio_tasklet);
+	tasklet_kill(&host->pio_tasklet);
 
 	if (s3cmci_host_usedma(host))
 		s3c2410_dma_free(host->dma, &s3cmci_dma_client);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/