linux-kernel - Re: [tip:perf/core] trace: Move trace event enable from fs_initcall to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALF0-+Vv0mS6ENOpG4x6-922XEik5JM=4+5A+5ZWVtgZmNyJBA@mail.gmail.com>
Date:	Wed, 31 Oct 2012 08:19:57 -0300
From:	Ezequiel Garcia <elezegarcia@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	rostedt@...dmis.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org, Tim Bird <tim.bird@...sony.com>
Subject: Re: [tip:perf/core] trace: Move trace event enable from fs_initcall
 to core_initcall

Hi Pekka,

On Wed, Oct 31, 2012 at 4:04 AM, Pekka Enberg <penberg@...nel.org> wrote:
> Hi Ezequiel,
>
> On Thu, Sep 27, 2012 at 8:49 AM, tip-bot for Ezequiel Garcia
> <elezegarcia@...il.com> wrote:
>> Commit-ID:  8781915ad2716adcd8cd5cc52cee791fc8b00fdf
>> Gitweb:     http://git.kernel.org/tip/8781915ad2716adcd8cd5cc52cee791fc8b00fdf
>> Author:     Ezequiel Garcia <elezegarcia@...il.com>
>> AuthorDate: Wed, 12 Sep 2012 11:47:57 -0300
>> Committer:  Steven Rostedt <rostedt@...dmis.org>
>> CommitDate: Mon, 24 Sep 2012 14:13:02 -0400
>>
>> trace: Move trace event enable from fs_initcall to core_initcall
>>
>> This patch splits trace event initialization in two stages:
>>  * ftrace enable
>>  * sysfs event entry creation
>>
>> This allows to capture trace events from an earlier point
>> by using 'trace_event' kernel parameter and is important
>> to trace boot-up allocations.
>>
>> Note that, in order to enable events at core_initcall,
>> it's necessary to move init_ftrace_syscalls() from
>> core_initcall to early_initcall.
>>
>> Link: http://lkml.kernel.org/r/1347461277-25302-1-git-send-email-elezegarcia@gmail.com
>>
>> Signed-off-by: Ezequiel Garcia <elezegarcia@...il.com>
>> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
>
> So what's still needed for perf to be able to trace early boot slab
> allocations like kmemtrace used to be able to do?
>

Steven suggested [1] it would be possible to create some sort
of static ring buffer, and use it to trace early events.
Later on, this static buffer should be copied into the "real" one.

Since this patch, ftrace is enabled at core_initcall.
It's an improvement, but we still loose events.
For instance, in a probe kernel we loose 800k bytes,
and 20k allocations, compared to accounting from boot up.

To be able to use ftrace (and therefore perf) for long run tracing,
you need to consider ring buffer overrun.
In my tests, I had to set a bigger buffer,
which severely impacts performance.

IMHO, this makes ftrace unsuitable for very long run tests
with "verbose" events; unless you put an user daemon
or something popping events, preventing overrun.

    Ezequiel

[1] https://lkml.org/lkml/2012/8/17/253
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/