linux-kernel - Re: [Patch v1 07/10] perf tools: add mem access sampling core support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBRqCOBoQc2s5ggmn5_4DrfJaTs0HBDCddW+AhYhJ1sRhQ@mail.gmail.com>
Date:	Wed, 31 Oct 2012 14:30:29 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...hat.com>, Lin Ming <ming.m.lin@...el.com>
Subject: Re: [Patch v1 07/10] perf tools: add mem access sampling core support

On Wed, Oct 31, 2012 at 6:51 AM, Namhyung Kim <namhyung@...nel.org> wrote:
> On Mon, 29 Oct 2012 16:15:49 +0100, Stephane Eranian wrote:
>> This patch adds the sorting and histogram support
>> functions to enable profiling of memory accesses.
>>
>> The following sorting orders are added:
>>  - symbol_daddr: data address symbol (or raw address)
>>  - dso_daddr: data address shared object
>>  - cost: access cost
>>  - locked: access uses locked transaction
>>  - tlb : TLB access
>>  - mem : memory level of the access (L1, L2, L3, RAM, ...)
>>  - snoop: access snoop mode
>>
>> Signed-off-by: Stephane Eranian <eranian@...gle.com>
>> ---
> [snip]
>> +/* --sort daddr_sym */
>> +static int64_t
>> +sort__daddr_cmp(struct hist_entry *left, struct hist_entry *right)
>> +{
>> +     struct addr_map_symbol *l = &left->mem_info->daddr;
>> +     struct addr_map_symbol *r = &right->mem_info->daddr;
>> +
>> +     return (int64_t)(r->addr - l->addr);
>> +}
>
> Doesn't it need to compare symbol (start address) if any, before doing
> it with raw addresses?
>
Possibly but we can't get to data symbols at the moment due to limitations
in kernel + perf tool.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/