lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 31 Oct 2012 15:33:26 +0200
From:	Felipe Balbi <balbi@...com>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
CC:	Dmytro Milinevskyy <milinevskyy@...il.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: ncm: correct endianess conversion

On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote:
> On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote:
> > I was trying to keep 2 tabs but checkpatch didn't accept long line
> > that's why I killed extra tab.
> 
> Then move them to the code section instead to initialize them in the
> declaration section.
> 
> > >How does it work? Is the test on host side not strict enough?
> > The host part(cdc_ncm) does not check this field.
> > However I agree that at least on device side this should be corrected.
> Good.
> 
> > Felipe, do you want me to send another patch or resend previous one
> > with this correction?
> If it hasn't been applied yet resend it.

I think I hasn't applied this one yet, so resending is the way to go.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists