linux-kernel - Re: [PATCH] hid-picolcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1210311451340.12781@pobox.suse.cz>
Date:	Wed, 31 Oct 2012 14:51:54 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Härdeman <david@...deman.nu>
Cc:	mchehab@...radead.org, sfr@...b.auug.org.au,
	bonbons@...ux-vserver.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid-picolcd_cir: fix compilation

On Wed, 31 Oct 2012, David Härdeman wrote:

> Commit c003ab1bedf0 ("[media] rc-core: add separate defines for
> protocol bitmaps and numbers") overlooked hid-picolcd.
> 
> This patch (against git.linuxtv.org/media_tree.git, branch
> staging/for_v3.8) fixes the compilation breakage.
> 
> Signed-off-by: David Härdeman <david@...deman.nu>
> ---
>  drivers/hid/hid-picolcd_cir.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-picolcd_cir.c b/drivers/hid/hid-picolcd_cir.c
> index 13ca919..a79e95b 100644
> --- a/drivers/hid/hid-picolcd_cir.c
> +++ b/drivers/hid/hid-picolcd_cir.c
> @@ -116,7 +116,7 @@ int picolcd_init_cir(struct picolcd_data *data, struct hid_report *report)
>  
>  	rdev->priv             = data;
>  	rdev->driver_type      = RC_DRIVER_IR_RAW;
> -	rdev->allowed_protos   = RC_TYPE_ALL;
> +	rdev->allowed_protos   = RC_BIT_ALL;
>  	rdev->open             = picolcd_cir_open;
>  	rdev->close            = picolcd_cir_close;
>  	rdev->input_name       = data->hdev->name;

This has been reported by Stephen a few days ago already ... Mauro, any 
plans to have that fixed up in media tree please?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/