linux-kernel - RE: [PATCH] [RFC]IRQ CORE: irq_work_queue function return value not used.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D854C92F57B1B347B57E531E78D05EAD2452296C@BGSMSX102.gar.corp.intel.com>
Date:	Wed, 31 Oct 2012 14:09:07 +0000
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	anish kumar <anish198519851985@...il.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"fweisbec@...il.com" <fweisbec@...il.com>
Subject: RE: [PATCH] [RFC]IRQ CORE: irq_work_queue function return value not
 used.


> -bool irq_work_queue(struct irq_work *work)
> +void irq_work_queue(struct irq_work *work)
>  {
> -	if (!irq_work_claim(work)) {
> -		/*
> -		 * Already enqueued, can't do!
> -		 */
> -		return false;
> -	}
> -
> +	/*
> +	 * This function either will claim the entry to queue
> +	 * the work or if the work is already queued and is in
> +	 * pending state then it will simply return.
> +	 */
> +	irq_work_claim(work)
>  	__irq_work_queue(work);
>  	return true;
>  }
You can remove the last return statement.

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/