linux-kernel - RE: [PATCH 0/2] mm: do not call frontswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c0d68556-54e7-479a-a7ae-6ca6f136d62d@default>
Date:	Wed, 31 Oct 2012 07:42:39 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Cesar Eduardo Barros <cesarb@...arb.net>, linux-mm@...ck.org
Cc:	linux-kernel@...r.kernel.org,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Johannes Weiner <hannes@...xchg.org>
Subject: RE: [PATCH 0/2] mm: do not call frontswap_init() during swapoff

> From: Cesar Eduardo Barros [mailto:cesarb@...arb.net]
> Sent: Saturday, October 27, 2012 3:21 PM
> To: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org; Konrad Rzeszutek Wilk; Dan Magenheimer; Andrew Morton; Mel Gorman;
> Rik van Riel; KAMEZAWA Hiroyuki; Johannes Weiner; Cesar Eduardo Barros
> Subject: [PATCH 0/2] mm: do not call frontswap_init() during swapoff
> 
> The call to frontswap_init() was added in a place where it is called not
> only from sys_swapon, but also from sys_swapoff. This pair of patches
> fixes that.
> 
> The first patch moves the acquisition of swap_lock from enable_swap_info
> to two separate helpers, one for sys_swapon and one for sys_swapoff. As
> a bonus, it also makes the code for sys_swapoff less subtle.
> 
> The second patch moves the call to frontswap_init() from the common code
> to the helper used only by sys_swapon.
> 
> Compile-tested only, but should be safe.
> 
> Cesar Eduardo Barros (2):
>   mm: refactor reinsert of swap_info in sys_swapoff
>   mm: do not call frontswap_init() during swapoff
> 
>  mm/swapfile.c | 26 +++++++++++++++++---------
>  1 file changed, 17 insertions(+), 9 deletions(-)

Belated but, I'm told, better late than never.

Minimally tested to ensure that frontswap continues
to work properly with some disk swap activity, not
exhaustively tested for swap in general.

Acked-by: Dan Magenheimer <dan.magenheimer@...cle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/