linux-kernel - Re: [PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Oct 2012 10:44:19 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	linux@....linux.org.uk, linux-tegra@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4

On 10/31/2012 03:02 AM, Laxman Dewangan wrote:
> Enable SLINK4 and connected device in Tegra30 based
> platform Cardhu.
> Setting maximum spi frequency to 25MHz.
> 
> Spi serial flash is connected on CS1 of SLINK4 on
> cardhu platform.

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt

> +winbond Winbond Electronics corp.

That should really be a separate patch that goes through the devicetree
branch. But I guess it's fairly trivial, so it's not a big deal.

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi

> +		spi-flash@1 {
> +			compatible = "winbond,w25q32";
> +			spi-max-frequency = <20000000>;
> +			reg = <1>;
> +		};

Since I have an Atmel flash on my board, I see:

[    1.282958] m25p80 spi32766.1: found at25df321a, expected w25q32
[    1.289103] m25p80 spi32766.1: at25df321a (4096 Kbytes)

Is there any way around that (the first log line above)?

I suppose the answer is that the DT should reflect the exact flash
device that's on the board, and perhaps the bootloader should be
adjusting the DT to reflect the correct value. That's probably complex.

Do you have any idea whether Atmel or Winbond flash is more common, so
we can at least minimize the number of times this message appears?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/