lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Oct 2012 17:48:55 +0100 From: Michal Hocko <mhocko@...e.cz> To: Tejun Heo <tj@...nel.org> Cc: lizefan@...wei.com, hannes@...xchg.org, bsingharora@...il.com, kamezawa.hiroyu@...fujitsu.com, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs On Wed 31-10-12 09:41:23, Tejun Heo wrote: > Hey, Michal. > > On Wed, Oct 31, 2012 at 03:37:51PM +0100, Michal Hocko wrote: > > > + for_each_subsys(cgrp->root, ss) > > > + if (ss->pre_destroy) > > > + WARN_ON_ONCE(ss->pre_destroy(cgrp)); > > > > Hmm, I am not sure I like this WARN_ON_ONCE. First it can happen for > > more than one controller and second we can just clear CGRP_WAIT_ON_RMDIR > > and return with EBUSY. The only possible failure at the moment is when a > > new task or a child group appear. > > I know it is not a big deal because it will disappear later in the > > series but it would be more readable IMO. > > The WARN_ON_ONCE() is just moved from the original > cgroup_call_pre_destroy(). We can add an error out there but that > makes future changes difficult. It's a chicken and egg problem. You > gotta break the loop somewhere. I do not think this is that hard. You can simply change the return path on pre_destroy error by BUG_ON in "cgroup: deactivate CSS's and mark cgroup dead before invoking ->pre_destroy()". There is no chicke&egg problem here because once the group is marked dead and css frozen then the existing callbacks cannot possibly fail. Or am I missing your point? -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists