linux-kernel - Re: [PATCH 6/9] kernel: padata : use this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0000013ab7edd68d-5524bd32-c5a1-4cd8-a467-ca565ee4c854-000000@email.amazonses.com>
Date:	Wed, 31 Oct 2012 17:45:48 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Shan Wei <shanwei88@...il.com>
cc:	steffen.klassert@...unet.com,
	Kernel-Maillist <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org
Subject: Re: [PATCH 6/9] kernel: padata : use this_cpu_ptr per-cpu helper

On Wed, 31 Oct 2012, Shan Wei wrote:

> From: Shan Wei <davidshan@...cent.com>
>
>
> Signed-off-by: Shan Wei <davidshan@...cent.com>
> ---
>  kernel/padata.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index 89fe3d1..70dffe8 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -204,7 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
>  		goto out;
>  	}
>
> -	queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
> +	queue = this_cpu_ptr(pd->pqueue);
>  	if (queue->cpu_index == next_queue->cpu_index) {

Its simpler to just remove the per_cpu op completely and change the if
statement to

	if (this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index))
{

..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/