linux-kernel - Re: [patch] x86, xen: fix build dependency when USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121101124912.GA10743@localhost.localdomain>
Date:	Thu, 1 Nov 2012 08:49:13 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	David Rientjes <rientjes@...gle.com>, JBeulich@...e.com
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86, xen: fix build dependency when USB_SUPPORT is not
 enabled

On Wed, Oct 31, 2012 at 10:42:30PM -0700, David Rientjes wrote:
> CONFIG_XEN_DOM0 must depend on CONFIG_USB_SUPPORT, otherwise there is no 
> definition of xen_dbgp_reset_prep() and xen_dbgp_external_startup() 
> resulting in the following link error:
> 
> drivers/built-in.o: In function `dbgp_reset_prep':
> (.text+0x1e03c5): undefined reference to `xen_dbgp_reset_prep'
> drivers/built-in.o: In function `dbgp_external_startup':
> (.text+0x1e0d55): undefined reference to `xen_dbgp_external_startup'

There is another patch that needs to be Acked and picked up by
Greg KH that fixes this.

Let me poke Jan Beulich to repost it with the appropiate Acks.
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  arch/x86/xen/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -17,6 +17,7 @@ config XEN_DOM0
>  	def_bool y
>  	depends on XEN && PCI_XEN && SWIOTLB_XEN
>  	depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
> +	depends on USB_SUPPORT
>  
>  # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
>  # name in tools.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/