linux-kernel - Re: [PATCH] usb: gadget: ncm: correct endianess conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Nov 2012 16:26:08 +0100
From:	Dmytro Milinevskyy <milinevskyy@...il.com>
To:	balbi@...com
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: ncm: correct endianess conversion

Hi Felipe,
resent with requested formatting changes.

cheers,
-- dmytro

On Wed, Oct 31, 2012 at 2:35 PM, Felipe Balbi <balbi@...com> wrote:
> Hi,
>
> On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote:
>> Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver.
>> Tested on MIPS32 big-endian device.
>>
>> Signed-off-by: Dmytro Milinevskyy <milinevskyy@...il.com>
>> ---
>>  drivers/usb/gadget/f_ncm.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
>> index b651b52..0b9e2ad 100644
>> --- a/drivers/usb/gadget/f_ncm.c
>> +++ b/drivers/usb/gadget/f_ncm.c
>> @@ -102,7 +102,7 @@ static inline unsigned ncm_bitrate(struct usb_gadget *g)
>>                                USB_CDC_NCM_NTB32_SUPPORTED)
>>  static struct usb_cdc_ncm_ntb_parameters ntb_parameters = {
>> -     .wLength = sizeof ntb_parameters,
>> +     .wLength = cpu_to_le16(sizeof(ntb_parameters)),
>>       .bmNtbFormatsSupported = cpu_to_le16(FORMATS_SUPPORTED),
>>       .dwNtbInMaxSize = cpu_to_le32(NTB_DEFAULT_IN_SIZE),
>>       .wNdpInDivisor = cpu_to_le16(4),
>> @@ -869,15 +869,15 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,
>>       struct sk_buff  *skb2;
>>       int             ncb_len = 0;
>>       __le16          *tmp;
>> -     int             div = ntb_parameters.wNdpInDivisor;
>> -     int             rem = ntb_parameters.wNdpInPayloadRemainder;
>> -     int             pad;
>> -     int             ndp_align = ntb_parameters.wNdpInAlignment;
>> -     int             ndp_pad;
>> +     int             div, rem, pad, ndp_align, ndp_pad;
>
> I would not combine them in a single line. Keep them one per line.
>
> cheers
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/