linux-kernel - Re: [ 26/85] usb: host: xhci: New system added for Compliance Mode Patch on SN65LVPE502CP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121101192517.GL29270@xanatos>
Date:	Thu, 1 Nov 2012 12:25:17 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	"Alexis R. Cortes" <alexis.cortes@...com>
Cc:	linux-kernel@...r.kernel.org, Ben Hutchings <ben@...adent.org.uk>,
	stable@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 26/85] usb: host: xhci: New system added for Compliance Mode
 Patch on SN65LVPE502CP

On Sat, Oct 27, 2012 at 06:18:13PM +0100, Ben Hutchings wrote:
> On Thu, 2012-10-25 at 17:05 -0700, Greg Kroah-Hartman wrote:
> > 3.6-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: "Alexis R. Cortes" <alexis.cortes@...com>
> > 
> > commit 470809741a28c3092279f4e1f3f432e534d46068 upstream.
> > 
> > This minor change adds a new system to which the "Fix Compliance Mode
> > on SN65LVPE502CP Hardware" patch has to be applied also.
> > 
> > System added:
> > Vendor: Hewlett-Packard. System Model: Z1
> [...]
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -479,7 +479,8 @@ static bool compliance_mode_recovery_tim
> >  
> >  	if (strstr(dmi_product_name, "Z420") ||
> >  			strstr(dmi_product_name, "Z620") ||
> > -			strstr(dmi_product_name, "Z820"))
> > +			strstr(dmi_product_name, "Z820") ||
> > +			strstr(dmi_product_name, "Z1"))
> 
> This will also match any future models with extra digits after the '1'.
> It might be worth using a slightly stricter match.

Hmm, Ben has a point.  We don't want to have the timer run on a machine
that really doesn't need the quirk, or we impact battery life.

Alex, can you make a new patch that fixes this?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/